Use Random.name instead of Random.string for node and taxonomy content. #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedstrom
added a commit
that referenced
this pull request
Nov 6, 2015
Use Random.name instead of Random.string for node and taxonomy content.
|
Makes sense to me. If folks are actually relying on the body field for certain tests, then they should probably be passing in explicit values anyway. Thanks! |
xurizaemon
pushed a commit
to xurizaemon/drupalextension
that referenced
this pull request
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The characters present in Random.string make the Pantheon security sniffer suspicious when they pass through the Behat Drush Endpoint.
Perhaps it would be sufficient to simplify here? This change shouldn't affect the robustness of the tests; if users specifically want to test certain characters in node creation, they could always explicitly use them in their test data.
Hope this is okay.