Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Drupal 6 core classes #154

Merged
merged 10 commits into from
Mar 25, 2015
Merged

Register Drupal 6 core classes #154

merged 10 commits into from
Mar 25, 2015

Conversation

dawehner
Copy link
Contributor

Fixes #153

This just registers the classes provided by the other PR

@jhedstrom
Copy link
Owner

Thanks for this! I'm working to get the current test failures fixed before merging this in.

@jhedstrom
Copy link
Owner

Tests are now all green. As discussed on IRC though, can you add the feature file from jhedstrom/DrupalDriver#26 as a test here? behat.yml.dist and .travis.yml will need to be updated accordingly.

@dawehner
Copy link
Contributor Author

Sure, let's give it a try

@dawehner
Copy link
Contributor Author

Expanded the support for taxonomy terms and tested it ... I guess in order to make the tests passing here, we need to commit the branch in drupal-driver itself?

On my local system they pass so far:

$ vendor/bin/behat -fprogress --profile=drupal6
...............
9 scenarios (9 passed)
15 steps (15 passed)
1m56.03s (8.57Mb)

@jhedstrom
Copy link
Owner

Can you temporarily update composer.json to point at your working branch in DrupalDriver? (See https://getcomposer.org/doc/05-repositories.md).

@dawehner
Copy link
Contributor Author

Ah, clever idea

On Mon, Mar 23, 2015 at 7:52 PM, Jonathan Hedstrom <notifications@github.com

wrote:

Can you temporarily update composer.json to point at your working branch
in DrupalDriver? (See https://getcomposer.org/doc/05-repositories.md).


Reply to this email directly or view it on GitHub
#154 (comment)
.

@jhedstrom
Copy link
Owner

Tests are green again if you want to rebase this.

@dawehner
Copy link
Contributor Author

Maybe it would be a good idea now to squash the commits into one?

@jhedstrom
Copy link
Owner

I've merged the DrupalDriver PR, so you can now switch composer.json back. You can squish the commits if you like, but don't have to.

@dawehner
Copy link
Contributor Author

Alright, let's "hop" its still green.

jhedstrom added a commit that referenced this pull request Mar 25, 2015
Register Drupal 6 core classes
@jhedstrom jhedstrom merged commit 446fddd into jhedstrom:master Mar 25, 2015
@jhedstrom
Copy link
Owner

Awesome! Thanks!

jhedstrom added a commit that referenced this pull request Mar 25, 2015
Register Drupal 6 core classes

Signed-off-by: Jonathan Hedstrom <jhedstrom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Drupal 6 for the drupalextension ~3.0
2 participants