Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.x requires PHP 5.4 #207

Closed
iamEAP opened this issue Sep 1, 2015 · 2 comments
Closed

3.1.x requires PHP 5.4 #207

iamEAP opened this issue Sep 1, 2015 · 2 comments

Comments

@iamEAP
Copy link
Contributor

iamEAP commented Sep 1, 2015

Looks like there were some bracket-style arrays introduced in the 3.1 release. Should either swap those, or explicitly set a PHP requirement in composer.json.

Parse error: syntax error, unexpected '[' in /path/to/vendor/drupal/drupal-extension/src/Drupal/DrupalExtension/Context/RawDrupalContext.php on line 288

There may be others.

jhedstrom added a commit that referenced this issue Sep 1, 2015
@jhedstrom
Copy link
Owner

That wasn't intentional. We had to stop testing on 5.3 due to composer dependencies that were never sorted for 5.3. I opened #208 to see if we can do something similar to what we do for Drupal 8 with a pinned composer.json example.

jhedstrom added a commit that referenced this issue Sep 1, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
jhedstrom added a commit that referenced this issue Sep 2, 2015
@jhedstrom
Copy link
Owner

PR is merged. I'm opening a follow-up to address the remaining tests that are failing (5.3 fails are currently configured to be ignored by Travis).

xurizaemon pushed a commit to xurizaemon/drupalextension that referenced this issue Nov 30, 2022
Remove php 5.5 testing and prep for 2.0.0 rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants