Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 4 as dependency #222

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Conversation

Berdir
Copy link
Contributor

@Berdir Berdir commented Feb 17, 2020

Requiring ~4.4 as that's what Drupal 9 requires anyway.

@Berdir
Copy link
Contributor Author

Berdir commented Feb 17, 2020

PHP 7.4 fails seem unrelated to this, phpunit and other dependencies will need to be updated to supported versions to fix that.

@jhedstrom
Copy link
Owner

Hmm, what should we do regarding the php 7.4 failure? I'm assuming this is still being sorted out in Drupal itself?

@Berdir
Copy link
Contributor Author

Berdir commented Feb 19, 2020

Latest drupal 8 dev should be 7.4 compatible, that doesn't seem to be the problem here but your own dependencies as far as I see.

You still require PHPUnit 4, Drupal 8 uses 6/7 while Drupal 9 uses Phpunit 8. And some other dependencies that might need to be updated too.

I'm not sure why 7.4 is even currently tested, this can't work right now in HEAD either?

@Berdir
Copy link
Contributor Author

Berdir commented Feb 19, 2020

Having a look at how much work it is to update those dependencies and if things break, but to me it would make more sense to do that in a separate PR :)

@jhedstrom jhedstrom merged commit 5292879 into jhedstrom:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants