Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container builds are not caching properly #153

Closed
jhatler opened this issue May 31, 2024 · 0 comments · Fixed by #155 or #68
Closed

Container builds are not caching properly #153

jhatler opened this issue May 31, 2024 · 0 comments · Fixed by #155 or #68
Labels
bug Something isn't working (dev)containers Everything container related

Comments

@jhatler
Copy link
Owner

jhatler commented May 31, 2024

I believe this is due the use of a timestamp in the janus container to mock more proper testing.
@jhatler jhatler added bug Something isn't working (dev)containers Everything container related labels May 31, 2024
jhatler added a commit that referenced this issue May 31, 2024
@jhatler
fix: improve caching for container builds
d71c67e 
This removes the timestamp from the Janus container build.

Additionally, labels were added to the images and the devcontaner test
process was updated to skip more unnecessary steps.

Fixes: #153
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
@jhatler jhatler mentioned this issue May 31, 2024
Merged
@jhatler jhatler linked a pull request May 31, 2024 that will close this issue
fix: improve caching for container builds #155
Merged
jhatler added a commit that referenced this issue May 31, 2024
@jhatler
fix: improve caching for container builds (#155)
951d667 
This removes the timestamp from the Janus container build.

Additionally, labels were added to the images and the devcontaner test
process was updated to skip more unnecessary steps.

Fixes: #153
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
@github-actions github-actions bot mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working (dev)containers Everything container related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve caching for container builds jhatler/janus
chore: release main jhatler/janus
1 participant
@jhatler