Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container images should be signed. #126

Closed
jhatler opened this issue May 29, 2024 · 0 comments · Fixed by #127 or #68
Closed

Container images should be signed. #126

jhatler opened this issue May 29, 2024 · 0 comments · Fixed by #127 or #68
Labels
(dev)containers Everything container related enhancement New feature or request

Comments

@jhatler
Copy link
Owner

jhatler commented May 29, 2024

An example on how to do this is here: https://github.com/actions/starter-workflows/blob/main/ci/docker-publish.yml
jhatler added a commit that referenced this issue May 29, 2024
@jhatler
feat: sign containers
d9e8323 
This adds container signing based on the GitHub Actions OpenID token,
cosign, and Rekor. The signing is taken care of in the actions, and the
workflows simply pass in a flag to enable it.

Fixes #126
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
jhatler added a commit that referenced this issue May 29, 2024
@jhatler
feat: sign containers
cfe4706 
This adds container signing based on the GitHub Actions OpenID token,
cosign, and Rekor. The signing is taken care of in the actions, and the
workflows simply pass in a flag to enable it.

Fixes: #126
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
@jhatler jhatler mentioned this issue May 29, 2024
Merged
jhatler added a commit that referenced this issue May 30, 2024
@jhatler
feat: sign containers
a4afdd5 
This adds container signing based on the GitHub Actions OpenID token,
cosign, and Rekor. The signing is taken care of in the actions, and the
workflows simply pass in a flag to enable it.

Fixes: #126
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
jhatler added a commit that referenced this issue May 30, 2024
@jhatler
feat: sign containers (#127)
194d03d 
This adds container signing based on the GitHub Actions OpenID token,
cosign, and Rekor. The signing is taken care of in the actions, and the
workflows simply pass in a flag to enable it.

Fixes: #126
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
@github-actions github-actions bot mentioned this issue May 30, 2024
Merged
@jhatler jhatler added (dev)containers Everything container related enhancement New feature or request labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
(dev)containers Everything container related enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sign containers jhatler/janus
chore: release main jhatler/janus
1 participant
@jhatler