Add .is-disabled state to Dropdown component #3686
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement.
Proposed solution
Add a
.is-disabled
class to the.dropdown-item
elementTradeoffs
None
Testing Done
Yes, I created a test environment where I used a
Dropdown
component and added a.is-disabled
class to a.dropdown-item
element. The results can be seen in the screenshot and GIF below:A dropdown with a disabled item:
![image](https://private-user-images.githubusercontent.com/7586388/272366371-a1e0b936-4b7f-4e5e-be89-437f2999eb91.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NzMxODAsIm5iZiI6MTcyNTU3Mjg4MCwicGF0aCI6Ii83NTg2Mzg4LzI3MjM2NjM3MS1hMWUwYjkzNi00YjdmLTRlNWUtYmU4OS00MzdmMjk5OWViOTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDVUMjE0ODAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjM4NzMzMGZhOTRhYTJhYmMzOTczN2Q1M2E2ZmMyZTY1Y2Y0OTNmM2Q3NzMxMTA2MGQwYmQ1NWU1ZjVhMDJmNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.U9OH52nGjCYeud64IiOKf70WT4RXZqMFvRCOmE0RDp0)
A GIF Showing the disabled behavior on :hover
![gif](https://private-user-images.githubusercontent.com/7586388/272366541-4b9ff01c-a549-4f9a-8466-a322a257ec4d.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NzMxODAsIm5iZiI6MTcyNTU3Mjg4MCwicGF0aCI6Ii83NTg2Mzg4LzI3MjM2NjU0MS00YjlmZjAxYy1hNTQ5LTRmOWEtODQ2Ni1hMzIyYTI1N2VjNGQuZ2lmP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDVUMjE0ODAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmI0ZGI1MjBlMDBlZGMxMDdhYTY0MjcxYTI2ZWYwOWVjOTdjNGY1NmE1Y2M3M2NlNGYxZWE0ZmYxYTBmNWVhMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.GdG69Qz6iUKNI_lvW9nVxOWJgNHrChl3iMd840WuVSA)
Changelog updated?
No.