Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/divide #3362

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Fix/divide #3362

merged 3 commits into from
Jun 18, 2021

Conversation

jgthms
Copy link
Owner

@jgthms jgthms commented Jun 18, 2021

This is a bugfix.

Dart Sass is deprecating slash divisions.

Proposed solution

Using a custom divide() function to avoid using a slash /.
Using multiplication * instead where easy/possible.

Tradeoffs

Testing Done

CSS output is similar.

Changelog updated?

Yes.

@jgthms jgthms merged commit d6d32e8 into master Jun 18, 2021
@jgthms jgthms deleted the fix/divide branch June 18, 2021 17:27
daniil4udo pushed a commit to daniil4udo/bulma-css-variables that referenced this pull request Jun 21, 2021
* Use custom divide function

* Add docs spacing table styles

* Update changelog
MartinRosenberg added a commit to Collabsalot/gatsby-starter-i18n-bulma that referenced this pull request Sep 7, 2021
kalwalt pushed a commit to kalwalt/gatsby-starter-i18n-bulma that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant