Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2739 add variables size for layout hero #2740

Merged
merged 4 commits into from
Jan 5, 2020
Merged

Fix #2739 add variables size for layout hero #2740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bcba45
Add variables size for layout hero
IvanFrescas Dec 14, 2019
b8bbd0c
Add variables size for layout hero
IvanFrescas Dec 14, 2019
f68a836
add vertical padding and hero-body variable
IvanFrescas Dec 14, 2019
217697a
Change variable tag to Yes on hero documentation
IvanFrescas Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions docs/_data/variables/layout/hero.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"by_name": {
"$hero-body-padding": {
"name": "$hero-body-padding",
"value": "3rem 1.5rem",
"type": "size"
},
"$hero-body-padding-small": {
"name": "$hero-body-padding-small",
"value": "1.5rem",
"type": "size"
},
"$hero-body-padding-medium": {
"name": "$hero-body-padding-medium",
"value": "9rem 1.5rem",
"type": "size"
},
"$hero-body-padding-large": {
"name": "$hero-body-padding-large",
"value": "18rem 1.5rem",
"type": "size"
}
},
"list": [
"$hero-body-padding",
"$hero-body-padding-small",
"$hero-body-padding-medium",
"$hero-body-padding-large"
],
"file_path": "layout/hero.sass"
}
2 changes: 1 addition & 1 deletion docs/documentation/customize/concepts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<div class="content">
<p>
Bulma is highly customizable thanks to <strong>415 Sass variables</strong> living across <strong>28 files</strong>.
Bulma is highly customizable thanks to <strong>419 Sass variables</strong> living across <strong>28 files</strong>.
</p>

<p>
Expand Down
2 changes: 1 addition & 1 deletion docs/documentation/layout/hero.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
meta:
colors: true
sizes: true
variables: false
variables: true
---

<div class="content">
Expand Down
17 changes: 9 additions & 8 deletions sass/layout/hero.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// Main container
$hero-body-padding: 3rem 1.5rem !default
$hero-body-padding-small: 1.5rem !default
$hero-body-padding-medium: 9rem 1.5rem !default
$hero-body-padding-large: 18rem 1.5rem !default

// Main container
.hero
align-items: stretch
display: flex
Expand Down Expand Up @@ -71,18 +75,15 @@
// Sizes
&.is-small
.hero-body
padding-bottom: 1.5rem
padding-top: 1.5rem
padding: $hero-body-padding-small
&.is-medium
+tablet
.hero-body
padding-bottom: 9rem
padding-top: 9rem
padding: $hero-body-padding-medium
&.is-large
+tablet
.hero-body
padding-bottom: 18rem
padding-top: 18rem
padding: $hero-body-padding-large
&.is-halfheight,
&.is-fullheight,
&.is-fullheight-with-navbar
Expand Down Expand Up @@ -140,4 +141,4 @@
.hero-body
flex-grow: 1
flex-shrink: 0
padding: 3rem 1.5rem
padding: $hero-body-padding