Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native upload button visible in latest Google Chrome #1976

Closed
wants to merge 1 commit into from
Closed

Native upload button visible in latest Google Chrome #1976

wants to merge 1 commit into from

Conversation

mm98
Copy link

@mm98 mm98 commented Jul 5, 2018

This is a bugfix.

Proposed solution

The recent Google Chrome on Windows and Mac seams to make the native file upload button visible, even though it should be hidden (which it is in Firefox and IE). I've managed to narrow it down to css height and width has no effect on the button itself, but only the text-field on the right. This solves #1969 and #1904.

Tradeoffs

The .file-input can't be set to display: none or visibility: hidden, since third-party plugins (like jQuery Validate) can't focus on the element. Twitter Bootstrap uses opacity: 0, and this works very well with third-party plugins.

Testing Done

Has tested on Windows 10 with Google Chrome, Firefox, Internet Explorer, Microsoft Edge and Safari (iOS).

This fixes the recent Google Chrome file upload bug (#1969 and #1904), in regards to the native file upload button being visible. It looks like css height and width has no effect on the button itself, but only the text field on the right side.
@kornicameister
Copy link

Yeah, that struck my project as well.
@jgthms do you think it'd be doable to pull in this fix as part of 0.7.2, if that's not out already ?

@kornicameister
Copy link

FYI: This only occurs in Chrome <= 69. I am also running unstable Chrome >=71 and that issue is not present there.

@jgthms jgthms closed this Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants