Native upload button visible in latest Google Chrome #1976
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix.
Proposed solution
The recent Google Chrome on Windows and Mac seams to make the native file upload button visible, even though it should be hidden (which it is in Firefox and IE). I've managed to narrow it down to css
height
andwidth
has no effect on the button itself, but only the text-field on the right. This solves #1969 and #1904.Tradeoffs
The
.file-input
can't be set todisplay: none
orvisibility: hidden
, since third-party plugins (like jQuery Validate) can't focus on the element. Twitter Bootstrap usesopacity: 0
, and this works very well with third-party plugins.Testing Done
Has tested on Windows 10 with Google Chrome, Firefox, Internet Explorer, Microsoft Edge and Safari (iOS).