-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add without-arrow class for navbar items #1919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be is-arrowless or something to match bulma syntax tho |
It removes the arrow in the items of the Navbar. Closes jgthms#1833
@patrickabkarian name changed! 👍 @jgthms is there something else to change? 🤔 |
@Ana06 It looks pretty good! I'm gonna take a closer look tomorrow. |
Thanks for writing the documentation and updating the changelog too. Few people actually do it when contributing. There's only a couple of things to change:
Cheers. |
Done! 😉 |
Fantastic! Thanks. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It removes the arrow in the items of the Navbar.
Closes #1833.
I have rebuilt the css and updated the documentation and the changelog. However the documentation generated css doesn't seem to include the changes:
Am I missing something? Is it maybe fixed to the current released version and is it ok like that? 🤔