add variables for background color of card header, content and footer #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd card-footer background
|
Don't want to crash the party, but "background-color: none" ist not valid. |
|
@oppenheimer- good remark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement.
I added 3 new variables to allow customization of the card background for:
Proposed solution
This PR allow to set the background differently for each part of a card:
card-header-background-colorcard-content-background-colorcard-footer-background-colorTradeoffs
None, the default behavior is unchanged (all 3 color are set to
noneby default)Testing Done
I have tested it on a personal website.
I checked all 3 cases with custom colors