Fix missing use of $pagination-color variable #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pagination-color variable is not being used anywhere, so setting it to something else doesn't do anything. This should change the colour of pagination-previous, pagination-next, and pagination-link classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement/bugfix.
The pagination-color variable is not being used anywhere, so setting it
to something else doesn't do anything. This should change the colour of
pagination-previous, pagination-next, and pagination-link classes.
Proposed solution
$pagination-colorshould be used in.pagination-previous,.pagination-next, and.pagination-link.Testing Done
Ran
npm run build-cssand saw the results changing the desired variable.