Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing a simple version of the native sass percentage function … #1549

Merged
merged 1 commit into from
Apr 8, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions sass/grid/columns.sass
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ $column-gap: 0.75rem !default
@for $i from 1 through 12
.columns.is-mobile > &.is-#{$i}
flex: none
width: ($i / 12) * 100%
width: percentage($i / 12)
.columns.is-mobile > &.is-offset-#{$i}
margin-left: ($i / 12) * 100%
margin-left: percentage($i / 12)
+mobile
&.is-narrow-mobile
flex: none
Expand Down Expand Up @@ -116,9 +116,9 @@ $column-gap: 0.75rem !default
@for $i from 1 through 12
&.is-#{$i}-mobile
flex: none
width: ($i / 12) * 100%
width: percentage($i / 12)
&.is-offset-#{$i}-mobile
margin-left: ($i / 12) * 100%
margin-left: percentage($i / 12)
+tablet
&.is-narrow,
&.is-narrow-tablet
Expand Down Expand Up @@ -194,10 +194,10 @@ $column-gap: 0.75rem !default
&.is-#{$i},
&.is-#{$i}-tablet
flex: none
width: ($i / 12) * 100%
width: percentage($i / 12)
&.is-offset-#{$i},
&.is-offset-#{$i}-tablet
margin-left: ($i / 12) * 100%
margin-left: percentage($i / 12)
+touch
&.is-narrow-touch
flex: none
Expand Down Expand Up @@ -252,9 +252,9 @@ $column-gap: 0.75rem !default
@for $i from 1 through 12
&.is-#{$i}-touch
flex: none
width: ($i / 12) * 100%
width: percentage($i / 12)
&.is-offset-#{$i}-touch
margin-left: ($i / 12) * 100%
margin-left: percentage($i / 12)
+desktop
&.is-narrow-desktop
flex: none
Expand Down Expand Up @@ -309,9 +309,9 @@ $column-gap: 0.75rem !default
@for $i from 1 through 12
&.is-#{$i}-desktop
flex: none
width: ($i / 12) * 100%
width: percentage($i / 12)
&.is-offset-#{$i}-desktop
margin-left: ($i / 12) * 100%
margin-left: percentage($i / 12)
+widescreen
&.is-narrow-widescreen
flex: none
Expand Down Expand Up @@ -366,9 +366,9 @@ $column-gap: 0.75rem !default
@for $i from 1 through 12
&.is-#{$i}-widescreen
flex: none
width: ($i / 12) * 100%
width: percentage($i / 12)
&.is-offset-#{$i}-widescreen
margin-left: ($i / 12) * 100%
margin-left: percentage($i / 12)
+fullhd
&.is-narrow-fullhd
flex: none
Expand Down Expand Up @@ -423,9 +423,9 @@ $column-gap: 0.75rem !default
@for $i from 1 through 12
&.is-#{$i}-fullhd
flex: none
width: ($i / 12) * 100%
width: percentage($i / 12)
&.is-offset-#{$i}-fullhd
margin-left: ($i / 12) * 100%
margin-left: percentage($i / 12)

.columns
margin-left: (-$column-gap)
Expand Down