-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barely visible input placeholder in Firefox #2886
Comments
Can you provide a screenshot? |
Probably same issue as #2885 |
Just tested with revert of 5ba407b, the problem still exists. |
Hi, I don't want to open a new issue because it's maybe the same error. If I open bulma.io -> form with FF v74 (left screenshot), the color of placeholder is different than in Chromium v80 (right). |
In order to make it cross browser compatible the RGBA value needs to be replaced, as it doesn't work for Firefox. It adds up the color's opacity, set in Bulma, with the base opacity of Firefox. https://github.com/jgthms/bulma/blob/master/sass/form/shared.sass#L19 L19:
L52:
This will not have any negative effect on peoples' current settings for relates to #2168: https://github.com/jgthms/bulma/search?q=%24input-disabled-placeholder-color&unscoped_q=%24input-disabled-placeholder-color (sorry for the many little edits) Note: changing this might also (positively!?) affect #2891 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@jgthms what do you think of my suggestion above? RGB + opacity works in all browsers, while RGBA values only in some. |
I can also confirm that the placeholders are barely visible on FireFox, please fix in coming release @jgthms |
As a workaround, set the placeholder color variable to whatever color you actually want it to be: $input-placeholder-color: #999; And then make sure Firefox shows it at 100% opacity: ::placeholder {
opacity: 1; // For Firefox.
} I do think it'd make sense to add that |
This is a bug fix. Issue: jgthms#2886 TL;DR Firefox and Safari/Chrome have different computed styles for placeholders. The current implementation only targets Safari/Chrome and renders them too faint in Firefox. ### Proposed solution Split the single RGBA color value into a solid color and an opacity value. This renders the placeholder the same in all browsers. ### Tradeoffs Users who change the alpha values of `$input-placeholder-color` and `$input-disabled-placeholder-color`, would have to set that alpha value now in the new `$input-placeholder-opacity` and `$input-disabled-placeholder-opacity`. No changes if the alpha value has not been altered.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@jgthms you mind taking a quick look. It's a pretty small change. Cheers |
Bulma CSS framework, bug
Bulma version 0.8.2
Firefox Developer Edition 75.0b7
Description:
Firefox default
opacity: 0.5
for input/textarea placeholders makes them barely visible.The text was updated successfully, but these errors were encountered: