-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextcloud 31 compatibility #90
Comments
Same here.
|
We'll take a look when we get time (which isn't now). Nextcloud are a little keen on breaking changes on major API increments. I know that can mean breaking changes, but someone them tell that they don't have to break the API every single time... |
I think this might be a Job for |
@janLo have you tested it? |
Just about to. If it works, I'll make a PR. |
I haven't touched PHP for a long time but the changes are more mechanical - so it should be fine. I tested it (create/load/save/preview) in my instance and it works again with these changes. |
There is something else that has broken since version 31, in addition to ILogger. This is sharing. When sharing drawio files and transferring the link to another person, the file listing opens briefly (i.e. there is access to the file), after which drawio starts loading and a redirect to the authorization page occurs |
That is true, but I think it's unrelated to the logger changes. I also see no drawio-related error in the log for this. The only thing I see is that the bruteForce app causes some exception - but that's just a DEBUG message - I don't know if it has anything to do with the issue. |
It's indeed another change in the NC API - I have currently no setup where I can "recompile" the JS part of this plugin for testing, but the path to a fix should be the same as the one the richdocuments plugin took: https://github.com/nextcloud/richdocuments/pull/4030/files Nevertheless, the logging fix is the first step to make the plugin work again at all ;) |
NC 31 does not provide the sahring token in an invisible HTML element anymore. This fixes this issue by using the path of the richdocuments plugin here: https://github.com/nextcloud/richdocuments/pull/4030/files This refers to jgraph#90
I've provided the changes from richdocuments in #92, but haven't tested them yet. |
NC 31 does not provide the sahring token in an invisible HTML element anymore. This fixes this issue by using the path of the richdocuments plugin here: https://github.com/nextcloud/richdocuments/pull/4030/files This refers to jgraph#90
The app seems to be broken on Nextcloud 31. Please make it available for this version.
The text was updated successfully, but these errors were encountered: