Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 31 compatibility #90

Closed
Mer0me opened this issue Feb 26, 2025 · 11 comments · Fixed by #91
Closed

Nextcloud 31 compatibility #90

Mer0me opened this issue Feb 26, 2025 · 11 comments · Fixed by #91

Comments

@Mer0me
Copy link

Mer0me commented Feb 26, 2025

The app seems to be broken on Nextcloud 31. Please make it available for this version.

@Bad-and-Mad
Copy link

Same here.

"Could not boot drawio: Call to undefined method OC\\Server::getLogger()"

@davidjgraph
Copy link
Contributor

We'll take a look when we get time (which isn't now). Nextcloud are a little keen on breaking changes on major API increments. I know that can mean breaking changes, but someone them tell that they don't have to break the API every single time...

@jgraph jgraph deleted a comment from Phangyesheng Mar 3, 2025
@janLo
Copy link
Contributor

janLo commented Mar 4, 2025

I think this might be a Job for sed: https://github.com/nextcloud/server/pull/40145/files

@davidjgraph
Copy link
Contributor

@janLo have you tested it?

@janLo
Copy link
Contributor

janLo commented Mar 4, 2025

Just about to. If it works, I'll make a PR.

@janLo
Copy link
Contributor

janLo commented Mar 4, 2025

I haven't touched PHP for a long time but the changes are more mechanical - so it should be fine.

I tested it (create/load/save/preview) in my instance and it works again with these changes.
Thank you!

@igorehan
Copy link

igorehan commented Mar 4, 2025

There is something else that has broken since version 31, in addition to ILogger. This is sharing. When sharing drawio files and transferring the link to another person, the file listing opens briefly (i.e. there is access to the file), after which drawio starts loading and a redirect to the authorization page occurs

@janLo
Copy link
Contributor

janLo commented Mar 5, 2025

That is true, but I think it's unrelated to the logger changes. I also see no drawio-related error in the log for this. The only thing I see is that the bruteForce app causes some exception - but that's just a DEBUG message - I don't know if it has anything to do with the issue.

@janLo
Copy link
Contributor

janLo commented Mar 5, 2025

The request that is made after the file listing is briefly shown redirects without the share token:

Image

I guess, that the plugin then just redirects to the login page:

Image

@janLo
Copy link
Contributor

janLo commented Mar 5, 2025

It's indeed another change in the NC API - I have currently no setup where I can "recompile" the JS part of this plugin for testing, but the path to a fix should be the same as the one the richdocuments plugin took: https://github.com/nextcloud/richdocuments/pull/4030/files

Nevertheless, the logging fix is the first step to make the plugin work again at all ;)

janLo added a commit to janLo/drawio-nextcloud that referenced this issue Mar 5, 2025
NC 31 does not provide the sahring token in an invisible HTML element
anymore. This fixes this issue by using the path of the richdocuments
plugin here:
https://github.com/nextcloud/richdocuments/pull/4030/files

This refers to jgraph#90
@janLo
Copy link
Contributor

janLo commented Mar 5, 2025

I've provided the changes from richdocuments in #92, but haven't tested them yet.

janLo added a commit to janLo/drawio-nextcloud that referenced this issue Mar 5, 2025
NC 31 does not provide the sahring token in an invisible HTML element
anymore. This fixes this issue by using the path of the richdocuments
plugin here:
https://github.com/nextcloud/richdocuments/pull/4030/files

This refers to jgraph#90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants