Don't escape single quote (') as &jaspervdj#39;.

Argument: The only context in which ' needs to be escaped is inside a single-quoted attribute value. Since blaze-html uses double quotes around attribute values, it should never need to escape '.
jgm · Dec 18, 2011 · e42848d · e42848d
1 parent c614fb8
commit e42848d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/Text/Blaze/Renderer/String.hs b/Text/Blaze/Renderer/String.hs
@@ -26,7 +26,6 @@ escapeHtmlEntities (c:cs) k = case c of
     '>'  -> '&' : 'g' : 't' : ';'             : escapeHtmlEntities cs k
     '&'  -> '&' : 'a' : 'm' : 'p' : ';'       : escapeHtmlEntities cs k
     '"'  -> '&' : 'q' : 'u' : 'o' : 't' : ';' : escapeHtmlEntities cs k
-    '\'' -> '&' : '#' : '3' : '9' : ';'       : escapeHtmlEntities cs k
     x    -> x                                 : escapeHtmlEntities cs k
 
 -- | Render a 'ChoiceString'.

diff --git a/Text/Blaze/Renderer/Text.hs b/Text/Blaze/Renderer/Text.hs
@@ -31,7 +31,6 @@ escapeHtmlEntities = T.foldr escape mempty
     escape '>'  b = B.fromText "&gt;"   `mappend` b
     escape '&'  b = B.fromText "&amp;"  `mappend` b
     escape '"'  b = B.fromText "&quot;" `mappend` b
-    escape '\'' b = B.fromText "&#39;"  `mappend` b
     escape x    b = B.singleton x       `mappend` b
 
 -- | Render a 'ChoiceString'. TODO: Optimization possibility, apply static