Add support for external parents in a multi-module project #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multi-module maven projects where some child projects have parents that are external to the project structure ( for example spring-boot parent poms: https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-build-systems.html#using-boot-maven-parent-pom ).
These are identified by the fact that the relativePath for the parent is set to be empty
<relativePath/>
http://maven.apache.org/ref/3.0/maven-model/maven.html#parent
I have added an integration test (
multi-external-parent
) which fails to build under the current code and then passes with my proposed fix. The build fails as the version number for the external parent pom is incorrectly re-written by the jgitver-maven-plugin.Could you review this change and see if you agree?
Many thanks
David