Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external parents in a multi-module project #73

Closed
wants to merge 2 commits into from
Closed

Add support for external parents in a multi-module project #73

wants to merge 2 commits into from

Conversation

driseley
Copy link
Contributor

We have multi-module maven projects where some child projects have parents that are external to the project structure ( for example spring-boot parent poms: https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-build-systems.html#using-boot-maven-parent-pom ).

These are identified by the fact that the relativePath for the parent is set to be empty <relativePath/>

http://maven.apache.org/ref/3.0/maven-model/maven.html#parent

Set the value to an empty string in case you want to disable the feature and always resolve the parent POM from the repositories

I have added an integration test ( multi-external-parent ) which fails to build under the current code and then passes with my proposed fix. The build fails as the version number for the external parent pom is incorrectly re-written by the jgitver-maven-plugin.

Could you review this change and see if you agree?

Many thanks
David

@driseley driseley changed the title Add support for external parents in a multi-module repository Add support for external parents in a multi-module project Jan 18, 2018
@McFoggy McFoggy self-requested a review January 18, 2018 14:03
@McFoggy McFoggy self-assigned this Jan 18, 2018
@McFoggy
Copy link
Contributor

McFoggy commented Jan 18, 2018

thank you for this very promising contribution, will review ASAP.

@McFoggy
Copy link
Contributor

McFoggy commented Jan 23, 2018

Thank you very much for your help.

I integrated your commit in 167c67c.

@McFoggy McFoggy closed this Jan 23, 2018
@McFoggy McFoggy removed their request for review January 23, 2018 07:33
@driseley
Copy link
Contributor Author

@McFoggy - many thanks for accepting this , is there any chance we could have a release of this fix, as this would allow us to stop using our locally forked version?

@driseley driseley deleted the exclude-parents branch January 23, 2018 11:05
@McFoggy
Copy link
Contributor

McFoggy commented Jan 23, 2018

It is tagged & released on sonatype. Just wait few hours for central to be in synch.

@driseley
Copy link
Contributor Author

That's brilliant - many thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants