Fix io.time tap.

jgilbert01 · Jul 2, 2024 · c04425b · c04425b
1 parent 0308af3
commit c04425b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/src/metrics/pipelines.js b/src/metrics/pipelines.js
@@ -103,7 +103,7 @@ class PipelineMetrics {
     const self = this;
     self.startStep(step);
     return Promise.resolve(p()) // now start the promise
-      .tap(self.endStep(step));
+      .tap(() => self.endStep(step));
   }
 }
 

diff --git a/test/unit/metrics/index.test.js b/test/unit/metrics/index.test.js
@@ -182,24 +182,24 @@ describe('metrics/index.js', () => {
             count: 3,
           },
           'p1|save|stream.pipeline.io.wait.time': {
-            average: 22,
-            min: 18,
+            average: 20,
+            min: 14,
             max: 26,
-            sum: 66,
+            sum: 60,
             count: 3,
           },
           'p1|save|stream.pipeline.io.time': {
-            average: 2,
-            min: 2,
-            max: 2,
-            sum: 6,
+            average: 8,
+            min: 8,
+            max: 8,
+            sum: 24,
             count: 3,
           },
           'p1|stream.pipeline.time': {
-            average: 2046,
-            min: 2044,
-            max: 2048,
-            sum: 6138,
+            average: 2044,
+            min: 2042,
+            max: 2046,
+            sum: 6132,
             count: 3,
           },
           'p2|stream.channel.wait.time': {
@@ -224,26 +224,26 @@ describe('metrics/index.js', () => {
             count: 1,
           },
           'p2|get|stream.pipeline.io.wait.time': {
+            average: 8,
+            min: 8,
+            max: 8,
+            sum: 8,
+            count: 1,
+          },
+          'p2|get|stream.pipeline.io.time': {
             average: 14,
             min: 14,
             max: 14,
             sum: 14,
             count: 1,
           },
-          'p2|get|stream.pipeline.io.time': {
+          'p2|publish|stream.pipeline.io.wait.time': {
             average: 2,
             min: 2,
             max: 2,
             sum: 2,
             count: 1,
           },
-          'p2|publish|stream.pipeline.io.wait.time': {
-            average: 8,
-            min: 8,
-            max: 8,
-            sum: 8,
-            count: 1,
-          },
           'p2|publish|stream.pipeline.io.time': {
             average: 2,
             min: 2,