Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where headingOffsets went out-of-sync on window resize #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 38 additions & 18 deletions lib/toc.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,45 @@ $.fn.toc = function(options) {
$(e.target).parent().addClass(activeClassName);
};

//highlight on scroll
var timeout;
var highlightOnScroll = function(e) {
if (timeout) {
clearTimeout(timeout);
}
timeout = setTimeout(function() {
var top = $(window).scrollTop(),
highlighted;
for (var i = 0, c = headingOffsets.length; i < c; i++) {
if (headingOffsets[i] >= top) {
$('li', self).removeClass(activeClassName);
highlighted = $('li:eq('+(i-1)+')', self).addClass(activeClassName);
opts.onHighlight(highlighted);
break;
}
var debounce = function(func, ms) {
var timeout;
return function() {
var that = this;
if (timeout) {
clearTimeout(timeout);
}
}, 50);
var callThen = function() {
timeout = null;
func.call(that);
};
timeout = setTimeout(callThen, ms);
};
};

//highlight on scroll
var highlightOnScroll = debounce(function() {
var top = $(window).scrollTop(),
highlighted;
for (var i = 0, c = headingOffsets.length; i < c; i++) {
if (headingOffsets[i] >= top) {
$('li', self).removeClass(activeClassName);
highlighted = $('li:eq('+(i-1)+')', self).addClass(activeClassName);
opts.onHighlight(highlighted);
break;
}
}
}, 50);
var recalculateOffsets = debounce(function() {
headingOffsets.length = 0;
headings.each(function(i, heading) {
var $h = $(heading);
headingOffsets.push($h.offset().top - opts.highlightOffset);
});
}, 50);
if (opts.highlightOnScroll) {
$(window).bind('scroll', highlightOnScroll);
$(window).bind('orientationchange resize', recalculateOffsets);

highlightOnScroll();
}

Expand All @@ -52,7 +70,9 @@ $.fn.toc = function(options) {
var ul = $('<ul/>');
headings.each(function(i, heading) {
var $h = $(heading);
headingOffsets.push($h.offset().top - opts.highlightOffset);
if (opts.highlightOnScroll) {
headingOffsets.push($h.offset().top - opts.highlightOffset);
}

//add anchor
var anchor = $('<span/>').attr('id', opts.anchorName(i, heading, opts.prefix)).insertBefore($h);
Expand Down