Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling text template generation #9

Open
aaronjensen opened this issue Dec 1, 2016 · 5 comments
Open

Allow disabling text template generation #9

aaronjensen opened this issue Dec 1, 2016 · 5 comments
Assignees

Comments

@aaronjensen
Copy link
Contributor

The text template generation leaves quite a bit to be desired so we tend to write our own text templates manually.

For some reason, templates generated by smoothie are super slow with dialyzer.

It'd be great if we could disable text template generation so we could reduce the size of the template module and hopefully reduce the time it takes dialyzer to process the template module.

@jfrolich
Copy link
Owner

jfrolich commented Dec 2, 2016

Thanks for the feedback! Will look into this.

@stephenmoloney
Copy link
Collaborator

just curious, what are the text templates for?
I haven't had a need for them yet.
I'd be in favour of making them optional.

@jfrolich
Copy link
Owner

jfrolich commented Dec 2, 2016

For providing a plain text version of the email for clients that cannot handle HTML formatting.

@jfrolich
Copy link
Owner

jfrolich commented Dec 2, 2016

Agree with making them optional 👍

@stephenmoloney
Copy link
Collaborator

I can add an option for this. Will try get to it eventually. Should be easy to implement.

@stephenmoloney stephenmoloney self-assigned this Mar 31, 2017
jfrolich added a commit that referenced this issue May 24, 2017
Add HTML only option to skip generating text templates (#9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants