Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project_key validation and tests #53

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Update project_key validation and tests #53

merged 3 commits into from
Aug 9, 2022

Conversation

alexhung
Copy link
Member

@alexhung alexhung commented Aug 9, 2022

@alexhung alexhung requested a review from danielmkn August 9, 2022 00:16
@alexhung alexhung requested a review from mritunjaykumar August 9, 2022 00:18
@alexhung alexhung marked this pull request as ready for review August 9, 2022 00:18
mritunjaykumar
mritunjaykumar approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@mritunjaykumar mritunjaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhung alexhung merged commit 3ef41e6 into master Aug 9, 2022
@alexhung alexhung deleted the GH-21-update-project-key-validation branch August 9, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mritunjaykumar mritunjaykumar mritunjaykumar approved these changes

@danielmkn danielmkn danielmkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProjectKey does not accept a hyphen where UI does.
4 participants
@alexhung @mritunjaykumar @danielmkn @jfrogsolutioncicd