Optimized impact paths building #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… process of building impact paths. Improved both processes for better performance.
asafgabai
commented
Nov 23, 2023
src/main/java/com/jfrog/ide/idea/ui/webview/WebviewObjectConverter.java
Outdated
Show resolved
Hide resolved
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
requested changes
Nov 29, 2023
…aph-creation # Conflicts: # src/main/java/com/jfrog/ide/idea/scan/ScannerBase.java # src/main/java/com/jfrog/ide/idea/ui/webview/WebviewObjectConverter.java
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jfrog/jfrog-ide-webview#49
Separated the process of grouping dependencies in file nodes from the process of building impact paths.
Improved both processes for better performance.
Impact paths are built bottom-up (from the vulnerable dependency to the root of the project) to avoid scanning the whole dependency tree.
Dependencies of Maven projects are grouped in file nodes in a similar, more efficient way, to find out which modules depend on vulnerable dependencies, without the need to find all possible paths between these dependencies and the roots of all modules.