Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Git Repository Resource in Xray API's #1039

Merged
merged 50 commits into from
Dec 30, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 7, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Git Repository Resource

from Xray version 3.111.0 a new resource is available: Git Repository you can define it to a watch/policy/ignore rules....
It will generate violations based on the watches that are defined on the resource. ticket

  • Add options to pass Git Repository Url to act as a violation context in scan graph (similar to project, watches...)
  • adds the new git_repositories filter attribute in ignore-rule and watch
  • adds the new jas filter attributes in policy

New API to retrieve active watches on resource

Adds a new API to get active watches based on a given resource (git repo / projectKey)

Other Changes:

  • add validation on ignore rule if more than one filter is present at a single rule
  • Removing unused attributes and code (enrich)
  • Remove XscGitInfoContext from scan graph since its not related anymore

@attiasas attiasas added the improvement Automatically generated release notes label Nov 7, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@attiasas attiasas marked this pull request as ready for review November 10, 2024 13:15
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@attiasas attiasas added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request and removed improvement Automatically generated release notes labels Dec 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2024
xray/services/scan.go Outdated Show resolved Hide resolved
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed, see my comments

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@eyalbe4 eyalbe4 merged commit e342ed5 into jfrog:dev Dec 30, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants