Enhance download functionality to support RBV2

[oshratZairi]

• All tests have passed. If this feature is not already covered by the tests, new tests have been added.
• The pull request is targeting the dev branch.
• The code has been validated to compile successfully by running go vet ./....
• The code has been formatted properly using go fmt ./....

---

Enhance download functionality to support RBV2

[EyalDelarea]

What happens when the bundle is not in V2? the download commands continues as it as?

And also this is a generic download code with too much RBV2 references, maybe we should extract some logic to a one liner function to avoid it.

I would move this logic inside the prepareDownloadCommand.

[oshratZairi]

the logic is:
if we have the same rb-name in both rbv1 and rbv2 - we will take rbv2.
if the cmd dose not contain --bundle , it will remain as it is.
moved the logic.

[EyalDelarea]

Notice to change replaces before pushing :)

[EyalDelarea]

Let's remove this check from here and insert this logic inside the createDefaultDownloadSpec function. Since the context is already passed to the function, it can be checked inside.

[EyalDelarea]

Can we make the URLs constants with meaningful names so we understand their purposes? The same applies to the URL on line 247.

[EyalDelarea]

Can we also verify the download succeeded and not just failed? maybe check the existence of the file ?

[EyalDelarea]

Can we put all the source logic inside a function that will also explain why it should be different?

Something like this:

func getSourcePattern(c *cli.Context) (string, error) {
	if c.IsSet("bundle") {
		isRbv2, err := checkRbExistenceInV2(c)
		if err != nil {
			log.Debug("Error occurred while checking if the bundle exists in rbv2:", err.Error())
		} else if isRbv2 {
			return buildSourceForRbv2(c)
		}
	}
	return strings.TrimPrefix(c.Args().Get(0), "/"), nil
}

then the line will look like this:

return spec.NewBuilder().
		Pattern(getSourcePattern(c)).
		
		

[EyalDelarea]

@oshratZairi looks good!

Just to extract the last function and fix the static check and we are good to go 👍

[EyalDelarea]

this could also move inside the getSourcePattern function

[github-actions]

---

🐸 JFrog Frogbot