Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer - Improve the graceful stop mechanism #991

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Transfer - Improve the graceful stop mechanism #991

merged 2 commits into from
Oct 12, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 11, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on jfrog/gofrog#40
Improve the graceful stop mechanism (ctrl+c or --stop) by stop executing pending tasks.

@yahavi yahavi added the improvement Automatically generated release notes label Oct 11, 2023
@yahavi yahavi requested a review from eyalbe4 October 11, 2023 13:07
@yahavi yahavi self-assigned this Oct 11, 2023
@yahavi yahavi temporarily deployed to frogbot October 11, 2023 13:07 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@yahavi yahavi merged commit 33502ae into jfrog:dev Oct 12, 2023
7 of 8 checks passed
@yahavi yahavi deleted the better-cancel branch October 12, 2023 11:36
@chenrui333 chenrui333 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4