Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm audit may skip some dependencies #856

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Npm audit may skip some dependencies #856

merged 1 commit into from
Jul 3, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jul 3, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

When auditing npm projects with jf audit, bundled and peer dependencies may be skipped if they do not appear in the local cache.

To replicate the issue, follow these steps:

  1. Clone the repository https://github.com/npm/cli.
  2. Execute the command jf audit.
  3. Observe that instead of scanning 399 dependencies, only 2 are being scanned.

@yahavi yahavi requested a review from eyalbe4 July 3, 2023 12:45
@yahavi yahavi self-assigned this Jul 3, 2023
@yahavi yahavi temporarily deployed to frogbot July 3, 2023 12:45 — with GitHub Actions Inactive
@yahavi yahavi added the bug Something isn't working label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

@yahavi yahavi requested a review from sverdlov93 July 3, 2023 14:00
@yahavi yahavi merged commit 031df14 into jfrog:dev Jul 3, 2023
7 checks passed
@yahavi yahavi deleted the audit-fix branch July 3, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants