Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer config - Avoid deleting existing repos #850

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Transfer config - Avoid deleting existing repos #850

merged 2 commits into from
Jul 4, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jun 29, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

To prevent data loss when executing the jf rt transfer-config command twice, this pull request suggests modifying the command to make it skip the process of deleting and recreating existing repositories on the target server.
If a repository import is skipped, the following message will be displayed:

10:11:57 [🔵Info] Repository 'conda-local' already exists in the target Artifactory server. Skipping.
10:11:57 [🔵Info] Repository 'conda-remote' already exists in the target Artifactory server. Skipping.
10:11:57 [🔵Info] Repository 'conda' already exists in the target Artifactory server. Skipping.

@yahavi yahavi added the bug Something isn't working label Jun 29, 2023
@yahavi yahavi self-assigned this Jun 29, 2023
@yahavi yahavi temporarily deployed to frogbot June 29, 2023 08:55 — with GitHub Actions Inactive
@yahavi yahavi changed the title Transfer config - Skip creating existing repos Transfer config - Skip deleting existing repos Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@yahavi yahavi changed the title Transfer config - Skip deleting existing repos Transfer config - Avoid deleting existing repos Jul 4, 2023
@yahavi yahavi merged commit 45dd4f9 into jfrog:dev Jul 4, 2023
6 of 7 checks passed
@yahavi yahavi deleted the skip-existed branch July 4, 2023 06:05
@yahavi yahavi mentioned this pull request Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees

@yahavi yahavi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4