Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle args with spaces #848

Closed

Conversation

keeganjm-bsc
Copy link

@keeganjm-bsc keeganjm-bsc commented Jun 27, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@keeganjm-bsc
Copy link
Author

@yahavi, @eyalbe4 , @RobiNino frogbot needs approval to start deploying changes. How can I get this triggered to deploy? What needs to be done?

@keeganjm-bsc
Copy link
Author

@yahavi @eyalbe4 @RobiNino please review this PR.

@keeganjm-bsc
Copy link
Author

@yahavi @eyalbe4 @RobiNino please approve for Frogbot scan. All tests and analysis have passed. This PR is a dependency for another PR in the jfrog-cli project

@keeganjm-bsc
Copy link
Author

@yahavi @eyalb4doc @RobiNino Please approve this for the Frogbot Scan job so this PR can move forward.

@keeganjm-bsc
Copy link
Author

@yahavi @eyalbe4 @RobiNino please review and merge. This PR is a dependency for another PR IN Jfrog-cli project here jfrog/jfrog-cli#2029. We have been trying to get these changes merged for over 2 weeks now. Please review and merge these so we can move forward with this.

@yahavi yahavi changed the title Bug fix: gradle args with spaces Support Gradle args with spaces Jun 30, 2023
@yahavi yahavi temporarily deployed to frogbot June 30, 2023 13:25 — with GitHub Actions Inactive
@yahavi yahavi self-requested a review June 30, 2023 13:25
@yahavi yahavi added the bug Something isn't working label Jun 30, 2023
@github-actions
Copy link
Contributor


  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

yahavi
yahavi previously approved these changes Jun 30, 2023
@yahavi yahavi dismissed their stale review June 30, 2023 13:55

I checked this change on the JFrog CLI and I'm not conviced it solves the issue

@keeganjm-bsc
Copy link
Author

@yahavi can you elaborate more on this? It is similar to the changes that were required for mvn command.

@yahavi
Copy link
Member

yahavi commented Jun 30, 2023

@keeganjm-bsc I elaborated in pull requests at the JFrog CLi repository: jfrog/jfrog-cli#2029 (comment)

Please let me know what you think.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Dec 20, 2023

@keeganjm-bsc,
I believe this PR can be closed, since #1072 already addresses this issie.
Let me know if you think otherwise.

@eyalbe4 eyalbe4 closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants