Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Empty dirs are not transferred in diffs #839

Merged
merged 4 commits into from
Jun 25, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jun 25, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix the following error happens in the phase 2 of the transfer-files command:

unexpected error occurred during upload
org.artifactory.api.repo.exception.FileExpectedException: Expected a file but found a folder, at: repo-name:path/in/repo/dir-name

In the Diffs phase (phase 2), the JFrog CLI treats all items as files and uses the folder name as the file name. However, the Data Transfer plugin expects an empty "name" field when the item is a folder.

@yahavi yahavi added the bug Something isn't working label Jun 25, 2023
@yahavi yahavi requested review from eyalbe4 and RobiNino June 25, 2023 12:19
@yahavi yahavi self-assigned this Jun 25, 2023
@yahavi yahavi merged commit b1c921c into jfrog:dev Jun 25, 2023
1 check failed
@yahavi yahavi deleted the diff-empty-dirs branch June 25, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants