Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize audit code #819

Merged
merged 44 commits into from
Jun 21, 2023
Merged

Reorganize audit code #819

merged 44 commits into from
Jun 21, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jun 4, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

  • Remove duplicate fields from the GenericAuditCommand and AuditParams structs to eliminate redundancy and improve code clarity.
  • Reorganize the code in the audit files to enhance maintainability and readability.
  • Move the audit scan entry point to auditmanager.go for better code organization and separation of concerns.
  • Split the code into functions and refactor the Run function of the audit command to improve modularity and code structure.

omerzi and others added 22 commits April 5, 2023 10:15
* Improve UI for scan command (jfrog#706)

* Upgrade go version in go.mod to 1.20 (jfrog#732)

* Fix lint issues found (jfrog#733)

* Config transfer - ensure target not older than source (jfrog#721)

* Update tests environment - nuget and dotnet to version 6  (jfrog#734)

* Flatten audit graph (jfrog#736)

* Use gradle-dep-tree with Audit (jfrog#719)

---------

Co-authored-by: Sara Omari <114062096+sarao1310@users.noreply.github.com>
Co-authored-by: Eyal Ben Moshe <eyalbenmoshe@jfrog.com>
Co-authored-by: Michael Sverdlov <sverdlov93@gmail.com>
Co-authored-by: Yahav Itzhak <yahavi@users.noreply.github.com>
# Conflicts:
#	.github/workflows/analysis.yml
#	go.mod
#	go.sum
#	xray/audit/java/gradle.go
#	xray/commands/audit/generic/auditmanager.go
@omerzi omerzi added the improvement Automatically generated release notes label Jun 4, 2023
…ements

# Conflicts:
#	xray/audit/jas/applicabilitymanager.go
#	xray/commands/audit/generic/generic.go
xray/commands/audit/generic/auditmanager.go Outdated Show resolved Hide resolved
xray/utils/resultstable.go Show resolved Hide resolved
@omerzi omerzi merged commit 0be8be3 into jfrog:dev Jun 21, 2023
1 check failed
@omerzi omerzi deleted the generic-audit-improvements branch July 23, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants