Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switch statements and cleanup code #806

Merged
merged 5 commits into from
Jun 4, 2023

Conversation

talarian1
Copy link
Contributor

@talarian1 talarian1 commented May 24, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR introduces the following changes:

  1. Fixes a minor bug regarding gradle cases in some switch cases. (The go default switch behavior is not to fall through cases. To achieve that, the ',' notation or the keywords fallthrough is necessary)
  2. Replace the fallthrough with the ',' notation for better readability .
  3. Remove the filterColor that I believe was not used.

@talarian1 talarian1 added the ignore for release Automatically generated release notes label May 24, 2023
@talarian1 talarian1 merged commit e758cdc into jfrog:dev Jun 4, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants