-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JFrog Advanced Security - Secrets & IaC scans #788
Conversation
…lity-column # Conflicts: # xray/commands/audit/generic/auditmanager.go # xray/commands/scan/buildscan.go # xray/formats/conversion.go # xray/formats/table.go # xray/utils/resultstable.go # xray/utils/resultstable_test.go # xray/utils/resultwriter.go
# Conflicts: # xray/commands/audit/generic/jas/applicabilityscanner.go # xray/commands/audit/generic/jas/generic.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished going over the entire code yet, but I'm releasing what I have so far. Feel free to go ahead and implement my comments.
In addition to my inline comments:
Only commands should be under the commands
or commands/audit
package. Therefore, the ApplicabilityScanManager
, IacScanManager
, jasmanager.go
and SecretScanManager
should move to a new package named jas
under jfrog-cli-core/xray/audit
.
# Conflicts: # xray/utils/analyzermanager.go # xray/utils/resultwriter.go
This PR includes the following:
Output examples - table:
Output examples - simple-json: