Improve get filtered repositories code #1280
Merged
+41
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sverdlov93
commented
Oct 10, 2024
sverdlov93
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
…x-template # Conflicts: # go.mod # go.sum
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
…x-template # Conflicts: # go.mod # go.sum
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
sverdlov93
commented
Oct 10, 2024
common/commands/configfile.go
Outdated
Comment on lines
654
to
666
| sm, err := utils.CreateServiceManager(artDetails, 3, 0, false) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| repos := []string{} | ||
| for _, repoType := range repoTypes { | ||
| filteredRepos, err := utils.GetFilteredRepositoriesWithFilterParams(sm, nil, nil, services.RepositoriesFilterParams{RepoType: repoType.String()}) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed getting %s repositories list: %w", repoType, err) | ||
| } | ||
| repos = append(repos, filteredRepos...) | ||
| } | ||
| return repos, nil |
There was a problem hiding this comment.
just moved from repoutils to here
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
yahavi
requested changes
Oct 10, 2024
Co-authored-by: Yahav Itschak <yahavi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.