Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root module name handling in build info collection #1201

Merged
merged 13 commits into from
Jul 30, 2024
Merged

Fix root module name handling in build info collection #1201

merged 13 commits into from
Jul 30, 2024

Commits on Jul 15, 2024

  1. Fix missing root module id

    @EyalDelarea
    EyalDelarea committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3fda9d3 View commit details
    Browse the repository at this point in the history

  2. Make the solution generic

    @EyalDelarea
    EyalDelarea committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f35be00 View commit details
    Browse the repository at this point in the history

  3. Extract from getModule function

    @EyalDelarea
    EyalDelarea committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7666f1a View commit details
    Browse the repository at this point in the history

  4. Fix diff

    @EyalDelarea
    EyalDelarea committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ff1910e View commit details
    Browse the repository at this point in the history

  5. Test comment

    @EyalDelarea
    EyalDelarea committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2e153b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into 23… 

    …66-module-id-missing-in-npm-build-info
    @EyalDelarea
    EyalDelarea committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    05af845 View commit details
    Browse the repository at this point in the history

  2. Return error if fail to get base dir

    @EyalDelarea
    EyalDelarea committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    c3124db View commit details
    Browse the repository at this point in the history

  3. Fix static checks

    @EyalDelarea
    EyalDelarea committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    27b171c View commit details
    Browse the repository at this point in the history

  4. Fix inner error declaration

    @EyalDelarea
    EyalDelarea committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    be876bd View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into 23… 

    …66-module-id-missing-in-npm-build-info
    @EyalDelarea
    EyalDelarea committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9513114 View commit details
    Browse the repository at this point in the history

  2. use path for windows

    @EyalDelarea
    EyalDelarea committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bf86521 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'dev' into 2366-module-id-missing-in-npm-build-info

    @RobiNino
    RobiNino authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    28d03ea View commit details
    Browse the repository at this point in the history

  2. CR comments

    @RobiNino
    RobiNino committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b71a019 View commit details
    Browse the repository at this point in the history