Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove applicabilityScannable attribute for technology #1154

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Remove applicabilityScannable attribute for technology #1154

wants to merge 3 commits into from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Mar 12, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This attribute is no longer needed. the new scanners will return a new status 'NOT_SCANNED' if not supported yet.

@attiasas attiasas added the ignore for release Automatically generated release notes label Mar 12, 2024
@attiasas attiasas mentioned this pull request Mar 12, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@hadarshjfrog
Copy link

hadarshjfrog commented Mar 24, 2024 •
edited
Loading

The code change itself looks good - my only concern - is how can we validate that when scanning a non-supported technology - just nothing well happened (as expected) - and not break anything?

Is it all handled here?
https://github.com/jfrog/jfrog-cli-security/pull/37/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranturgeman eranturgeman Awaiting requested review from eranturgeman

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @hadarshjfrog