Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Golang remote registry setting logic from security-cli to cli-core #1128

Merged

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Feb 13, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR introduces an new function that enables setting an Artifactory server as dependencies resolution registry for Golang projects.
This logic previously existed in security-cli, and got removed from there in this PR: jfrog/jfrog-cli-security#21

Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, try to rephrase the title

artifactory/commands/golang/go_test.go Outdated Show resolved Hide resolved
@attiasas attiasas added improvement Automatically generated release notes and removed ignore for release Automatically generated release notes labels Feb 15, 2024
@eranturgeman eranturgeman added ignore for release Automatically generated release notes and removed improvement Automatically generated release notes labels Feb 18, 2024
@eranturgeman eranturgeman changed the title Set Artifactory as dependencies resolution registry new function Moved Golang remote registry setting logic from security-cli to cli-core Feb 18, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@eranturgeman eranturgeman merged commit 9730505 into jfrog:dev Feb 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants