Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven support for curation audit cmd #1118

Merged
merged 10 commits into from
Feb 12, 2024
Merged

Maven support for curation audit cmd #1118

merged 10 commits into from
Feb 12, 2024

Conversation

asafambar
Copy link
Contributor

@asafambar asafambar commented Jan 25, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@eyalbe4 eyalbe4 self-requested a review January 25, 2024 14:21
@asafambar asafambar mentioned this pull request Feb 4, 2024
Merged
@attiasas attiasas added the improvement Automatically generated release notes label Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

attiasas
attiasas requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that uses the new attributes (curation and cache)

utils/java/mvn.go Outdated Show resolved Hide resolved
utils/java/mvn.go Outdated Show resolved Hide resolved
utils/java/mvn.go Show resolved Hide resolved
@yahavi yahavi merged commit d52f433 into jfrog:dev Feb 12, 2024
7 of 8 checks passed
@yahavi yahavi changed the title Maven support for curation audit cmd. Maven support for curation audit cmd Feb 12, 2024
@attiasas attiasas mentioned this pull request Feb 12, 2024
Closed
4 tasks
yahavi added a commit that referenced this pull request Feb 13, 2024
@yahavi
Revert "Maven support for curation audit cmd (#1118)"
35a8350 
This reverts commit d52f433.
@attiasas attiasas mentioned this pull request Feb 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asafambar @attiasas @eyalbe4 @yahavi