Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer - Limit max AQL threads to 16 #1032

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Transfer - Limit max AQL threads to 16 #1032

merged 3 commits into from
Nov 23, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 14, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Dependency for jfrog/jfrog-cli#2311

This pull request sets a cap on the maximum AQL threads to 32, aiming to decrease the load on the source Artifactory server. This specifically occurs at the start of phase 2 when all threads are simultaneously executing AQLs.

@yahavi yahavi added the improvement Automatically generated release notes label Nov 14, 2023
@yahavi yahavi requested a review from eyalbe4 November 14, 2023 16:01
@yahavi yahavi self-assigned this Nov 14, 2023
@yahavi yahavi mentioned this pull request Nov 14, 2023
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

eyalbe4
eyalbe4 requested changes Nov 20, 2023
View reviewed changes
artifactory/commands/transferfiles/transfer_test.go Outdated Show resolved Hide resolved
artifactory/commands/transferfiles/utils.go Outdated Show resolved Hide resolved
artifactory/commands/transferfiles/utils.go Outdated Show resolved Hide resolved
artifactory/utils/transfersettings.go Outdated Show resolved Hide resolved
@yahavi yahavi merged commit 6325ab6 into jfrog:dev Nov 23, 2023
7 of 8 checks passed
@yahavi yahavi deleted the limit-aql-threads branch November 23, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4