-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix root module name handling in build info collection #1201
Merged
RobiNino
merged 13 commits into
jfrog:dev
from
EyalDelarea:2366-module-id-missing-in-npm-build-info
Jul 30, 2024
Merged
Fix root module name handling in build info collection #1201
RobiNino
merged 13 commits into
jfrog:dev
from
EyalDelarea:2366-module-id-missing-in-npm-build-info
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalbe4
requested changes
Jul 15, 2024
yahavi
reviewed
Jul 15, 2024
yahavi
reviewed
Jul 15, 2024
EyalDelarea
changed the title
Fix missing root module ID for npm
Fix missing root module ID for build info
Jul 15, 2024
EyalDelarea
changed the title
Fix missing root module ID for build info
Fix missing root module ID for published build info
Jul 15, 2024
EyalDelarea
changed the title
Fix missing root module ID for published build info
Fix Default Module Name Handling in Build Info Collection
Jul 15, 2024
EyalDelarea
changed the title
Fix Default Module Name Handling in Build Info Collection
Fix default module name handling in build info collection
Jul 15, 2024
EyalDelarea
changed the title
Fix default module name handling in build info collection
Fix root module name handling in build info collection
Jul 15, 2024
EyalDelarea
force-pushed
the
2366-module-id-missing-in-npm-build-info
branch
from
July 15, 2024 14:55
3c52e30
to
2e153b9
Compare
…66-module-id-missing-in-npm-build-info
@yahavi i've changed the function to return error if fails to get working dir. |
…66-module-id-missing-in-npm-build-info
yahavi
reviewed
Jul 30, 2024
RobiNino
added a commit
to RobiNino/jfrog-cli-core
that referenced
this pull request
Jul 30, 2024
4 tasks
RobiNino
added a commit
that referenced
this pull request
Jul 30, 2024
Oh, This MR is to dev branch! |
Hi @EyalDelarea ,it should be the build-publish issue instead of bce issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description:
When collecting build information for different packages, if the module name is not specified in the descriptor file or provided as a CLI argument, it defaults to an empty string. This results in an error from the Artifactory server, stating that the module ID cannot be null.
In previous CLI versions, the default value was ":", which prevented crashes.
Fix:
If no module ID is provided, the default will now be set to the base directory of the module. This aligns with the default behavior of package descriptors init scripts.
As a last reasort the module name will resolve to "module" to be displayed at the UI and not fail on publish.