-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jersey2-api for jersey jars #838
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Have ran the unit tests and they are fine. This is a pretty helpful change as otherwise artifactory plugin conflicts with Gitlab plugin. |
Also, this uses a relatively old version of jersey2-api. These will be picked up by runtime, so it doesn't cause much issue in actual systems (will just use whatever jenkins is using.) However, going to a newer version requires massive changes to the pom (need to upgrade the plugin pom from 3.57 -> 4.xx), which is a lot more work then just doing above. |
Not sure what i am supposed to do here, will anyone review this? |
@eyalbe4 how are these tests set up? Is there a list of plugins that get installed, because if the jersey2-api plugin isn't in the plugins list i would guess this would fail. |
assuming you're using something like plugins.txt. |
Any help here? Not sure how i can solve this problem if the problem is just a missing dependency in the target test jenkins instance. |
Anyone? I am still quite sure this is just because the target jenkins instance does not include jersey2-api. |
Still don't know what i can do here.. |
@eyalbe4, sorry if this is the wrong person but I would really like this in. It's enough of a pain for me that i currently have to maintain a fork of the plugin. |
as I said earlier, my guess is this is now failing because the plugins.txt used in the jenkins instance does not include jersey2-api. |
As we see the very same issue here, can anybody please pick this up? |
I just maintain my own version now because I didn't get a response sadly |
@RobiNino is fine, I have worked around it for a while with my own fork anyway, but good for me to not need to maintain it anymore lol. Thanks! |
passed.
Closes #735