Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server ID in a configuration file #373

Merged
merged 9 commits into from
Jul 12, 2023
Merged

Use server ID in a configuration file #373

merged 9 commits into from
Jul 12, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jun 29, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • This pull request introduces a new usage for the JFrog Releases repository in Frogbot.
  • The server details will be saved as a JFrog server configuration file, similar to the JFrog CLI, with a server ID of "frogbot".
  • The releases repository, along with the server ID, will be saved as an environment variable. This follows the convention of the cli-core for downloading binaries from https://releases.jfrog.io/.

Depends on:
jfrog/jfrog-cli-core#851

@omerzi omerzi added the improvement Automatically generated release notes label Jun 29, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jun 29, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 29, 2023
@github-actions
Copy link
Contributor

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@omerzi omerzi requested a review from eyalbe4 July 4, 2023 05:11
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

sverdlov93
sverdlov93 reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this logic also help with the maven/gradle resolver repo?

commands/commands.go Outdated Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 12, 2023
@github-actions
Copy link
Contributor

@omerzi omerzi merged commit c2ab105 into jfrog:dev Jul 12, 2023
6 of 7 checks passed
@omerzi omerzi deleted the add-serverid branch July 23, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @sverdlov93