Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the resolution repository preemptive #122

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Aug 20, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

Make the resolution repository preemptive to handle cases where the user has enabled Hide Existence of Unauthorized Resources.

By default, Gradle sends an anonymous request during resolution and expects a 401 response from the server. However, when Hide Existence of Unauthorized Resources is active, Artifactory returns a 404 instead. This pull request addresses the issue by ensuring that Gradle sends credentials preemptively during resolution.

Refer to the Gradle documentation for more details on preemptive authentication.

@yahavi yahavi added the bug Something isn't working label Aug 20, 2024
@yahavi yahavi self-assigned this Aug 20, 2024
@yahavi yahavi added the safe to test Approve running tests on a pull request label Aug 20, 2024
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Aug 20, 2024
@yahavi yahavi requested a review from eyalbe4 August 20, 2024 11:38
@yahavi yahavi added the safe to test Approve running tests on a pull request label Aug 20, 2024
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Aug 20, 2024
@yahavi yahavi added the safe to test Approve running tests on a pull request label Aug 20, 2024
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Aug 20, 2024
@yahavi yahavi merged commit 171ce9a into jfrog:main Aug 20, 2024
9 of 10 checks passed
@yahavi yahavi deleted the premptive branch August 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants