-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #32 #49
Fixes #32 #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Just ignore the failing clippy CI test.
I just have a nitpick and a question: do you basically change the code to always have an xwhat
-error, which is possibly empty?
src/valgrind/mod.rs
Outdated
.map(|o_: xml::Output| { | ||
let mut o = o_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.map(|o_: xml::Output| { | |
let mut o = o_; | |
.map(|o: xml::Output| { |
Furthermore, couldn you please rename all o
s to output
?
Yes i took a quick look on serde and cant find a quick way to case-typing parsing so i just let it to be empty on failure. And then in the reporter I let it filter out the errors that doesnt have leaking info ( |
Thank you for your contribution, I'll make a release soon. |
@jfrimmel Any chance we could get a release on crates.io that includes this change? I've had this issue come up for me, and it looks like a new release with this PR included would fix it :) |
Oh, well, I've simply forgot doing it... I'll need an automatic release workflow in this repository... I've published version |
Fixes #32
An error might not contain
xwhat
, onlywhat
. This fix assumes that these errors are not a leaking error.An example one in my case: