Fix alignment's GetCurve for EdgeTX versions >= 2.9.0 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 8f3dd7f72e878607ab28af2b0c8ccca6e835fdd5[0] EdgeTX started to emit the curve elements with the first element in the list having the index 1. This is expected in LUA world but wasn't previously the case. SoarETX used to workaround the situation by rewriting the curve table. With this commit the curve table is only rewritten when the curve retrieved from EdgeTX does contain an element starting at position 0. [0]: EdgeTX/edgetx@8f3dd7f
|
SoarOTX is for OpenTX, not EdgeTX. SoarETX comes on the standard SD-card contents with EdgeTX, and this issue should have been fixed in EdgeTX/edgetx-sdcard#118 |
|
Ah! Thanks! I've not seen that it was integrated into the other repository. Sorry for the noise. |
|
One thing though: The edgetx-scard repo only contains a version for larger color displays, does that mean the SoarETX support for smaller bw displays (in this repository) isn't going to happen anymore? |
|
For BW radios I recommend using OpenTX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 8f3dd7f72e878607ab28af2b0c8ccca6e835fdd5 EdgeTX started to emit the curve elements with the first element in the list having the index 1. This is expected in LUA world but wasn't previously the case.
SoarETX used to workaround the situation by rewriting the curve table. With this commit the curve table is only rewritten when the curve retrieved from EdgeTX does contain an element starting at position 0.
I encountered this while trying SoarETX on RM Boxer (in the simulator) and on my new RM Pocket. On both the aileron alignment dialog works with this change. I've not tested older EdgeTX versions yet.