Big PR [DO NOT MERGE] #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, so this one is complicated. SemVer wise, we should be able to support glob 10 & glob 11. The only breaking change is the engine. Therefore, the "correct" specifier is indeed `^10.2.6 || ^11.0.0`. We support both, if you need an older engine, you should use an older version. In fact, npm is supposed to do this automatically. However, up until `npm-pick-manifest@9.1.0` (included in `npm@10.8.2`), there was a longstanding bug where it didn't! The code was there, but the logic didn't work right and after Isaacs moved on to vlt, his PR fixing this got stalled. After the `glob` fiasco, he rebased the PR and it's now fixed, but the change wasn't backported. Because we support Node 14, we support `npm@6.14.18`, so we can't take advantage of this. Instead, we just have to tolerate a slightly old version of glob. Oh well. I also removed "enginesStrict" because our engine declaration is now higher than technically needed because glob only declares support for the latest versions of Node branches.
- Sort `require`s.
- Move type imports above real imports.
- Switch to `@import` for imports needing `resolution-mode`.
- Enable `noUnusedLocals`.
- Move exports to the bottom of files.
- Switch an inline type import to an import declaration.
- Use `... = require('...').default` over `{default: ...} = require('...')`.
- Refactored `spinner.js` exports to be typesafe.
- Bumped TypeScript to fix some bugs.
fix: type error
Less dependency injection 🙁
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/ls-engines@0.9.2 |
|
Oh, I didn't even push the big branch. This is the small branch... 🤣 |
This was referenced Oct 31, 2024
Merged
Merged
Merged
Merged
|
Closing as superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XC has taken a big drain out of my time and energy, and I'm primarily posting this for posterity.
Someday, I'll rebase this and make it reviewable, for now, I just want to note some improvements that could be made by someone, hopefully me?
P.S., I know no stress 🙃 That's why I'm posting this, to put it somewhere I can know it's backed up and be accessed as needed.
Children:
rimrafwith nativerm#297