Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Engines #190

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Bump Engines #190

merged 2 commits into from
Jul 17, 2024

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jul 6, 2024 •
edited
Loading

Resolves #189.

@lishaduck lishaduck changed the title New engines Bump Engines Jul 6, 2024
@lishaduck

This comment was marked as outdated.

Sign in to view
@lishaduck lishaduck mentioned this pull request Jul 6, 2024
Open
23 tasks
@lishaduck

This comment was marked as outdated.

Sign in to view
@lishaduck
Copy link
Contributor Author

Might've found a workaround: getsentry/sentry-javascript#12793
I'll try it.

@lishaduck
Copy link
Contributor Author

lishaduck commented Jul 8, 2024 •
edited
Loading

Might've found a workaround: getsentry/sentry-javascript#12793 I'll try it.

No, that would prevent people from upgrading the packages on newer node. It should be set by application developers.
Essentially, I think we can ignore it, but there might be breaking changes to the lib soon (i.e., not just to the bin)

@lishaduck lishaduck mentioned this pull request Jul 8, 2024
Merged
@socket-security Socket Security
Copy link

socket-security bot commented Jul 8, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/terminal-link@2.1.1

View full report↗︎

jfmengels
jfmengels reviewed Jul 9, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@lishaduck lishaduck force-pushed the new-engines branch 3 times, most recently from 1510390 to 702e1c7 Compare July 9, 2024 21:43
@lishaduck
Copy link
Contributor Author

Ok, this PR now does the minimal work to make us compatible with latest glob.

This was referenced Jul 9, 2024
Closed
Merged
Merged
@lishaduck
Copy link
Contributor Author

Glob 11 just drops support again, I guess we should declare support for it as well.

@lishaduck
Copy link
Contributor Author

Ok, I guess we just have to trust ls-engines to keep us up-to-date here. We need to support Glob 11, but npm doesn't take the engine into account.

@lishaduck lishaduck requested a review from jfmengels July 9, 2024 22:16
@jfmengels jfmengels merged commit f0894b3 into jfmengels:main Jul 17, 2024
3 of 4 checks passed
@jfmengels
Copy link
Owner

Nice, I really like that we don't have to drop 2 major versions (well, 2 additional ones 😅 )

@lishaduck lishaduck deleted the new-engines branch July 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfmengels jfmengels Awaiting requested review from jfmengels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 14, 16 installs error again
2 participants
@lishaduck @jfmengels