TS Check, Lint, and Format new-package/ and vendor/
#187
Conversation
|
FYI, test failures are outdated snapshots, not #189, although that warning is visible in the logs. |
| console.error( | ||
| `There are extraneous dependencies in the ${exampleConfiguration}/ configuration: ${remainingKeys}` | ||
| // prettier-ignore |
There was a problem hiding this comment.
I have to admit I'm not fond of having disable checks (for prettier or for TS) in files that package authors will then own.
Maybe in this case, we can create a new variable const keys = remainingKeys.join(', '); above console.error(...)?
That should get rid of the need for the ignore.
There was a problem hiding this comment.
You marked this as resolved, but the comment is still here. Did you apply it on a different branch maybe?
There was a problem hiding this comment.
Let's resolve this later, let's not block all the other PRs because of this.
There was a problem hiding this comment.
Huh. Well, once it's all merged I can check again.
|
I'll merge this PR. We can always improve things later, I don't want you to fall into Git branch hell 😅 |
It's a bit too late for that 🤣 (it was worse, I rebased a few PRs and dropped some stashes): I mean, that's what summer break is for, eh? Finding projects? Enjoying not having to tune out teachers while you edit this and that? 😉 |
|
Right, but if I waited a few more days, who knows how much worse it would have been 😄 |
True, true... YIKES! |
Addresses @jfmengels's feedback from jfmengels#187 (comment). Co-authored-by: Jeroen Engels <jfm.engels@gmail.com>
Addresses @jfmengels's feedback from jfmengels#187 (comment). Co-authored-by: Jeroen Engels <jfm.engels@gmail.com>
Addresses @jfmengels's feedback from jfmengels#187 (comment). Co-authored-by: Jeroen Engels <jfm.engels@gmail.com>
Addresses @jfmengels's feedback from #187 (comment). Co-authored-by: Jeroen Engels <jfm.engels@gmail.com>
Part 1 of 2.
Relates: #125