Help refactor #174
Merged
Help refactor #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Jest run less often. Before now, Jest would run on every change. Also, ESLint now fails on warnings.
See (jfmengels#163)[jfmengels#163 (comment)] Co-authored-by: Jeroen Engels <jfm.engels@gmail.com>
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@typescript-eslint/eslint-plugin@5.62.0, npm/@typescript-eslint/parser@5.62.0, npm/eslint-plugin-node@11.1.0 |
This comment was marked as outdated.
This comment was marked as outdated.
lishaduck
force-pushed
the
help-refactor
branch
2 times, most recently
from
f9983cd to
a45324f
Compare
|
Ok, I decided to approach this differently then #126 did. It doesn't always return true, it can also never return and exit instead. I've update the types to reflect this. |
Merged
`eslint-plugin-n` is the maintained version of `eslint-plugin-node`.
It doesn't hurt.
Now that we only support Node 14.18 and later, we can use `node:`.
I just realized that I'd reverted the bump to Node 14.18. As I've gotten stuff dependent on 14.18 merged, I'm bumping it again. Oops. At least it's only a single minor. This also allows `node:` to stay.
XO removed it a while back, but it now supports ESLint 8.
This replaces `util.promisify` with `fs.promises` for all asynchronous operations. This also switches from `node:fs` to `graceful-fs` for all synchronous operations.
When possible, we now use async/await rather than callbacks. While a slight performance hit is likely incurred, the code is much more consistent. More Promise-based apis are available now than used to be the case.
Replace some jarring .then() chains with `async`/`await`.
Well, technically, it's @eslint-community/eslint-plugin-eslint-comments. Same difference. And hey, it caught something!
I hadn't previously realized that they didn't drop Node 16 until v7.
The plugin requires a newer version of Node to run on ESLint v8. Also, I ran `npm pkg fix`. It didn't find anything. In conclusion, I sorted the package.json file via `npx sort-package-json`.
This makes try/catch more predictable.
I figured this was a hangover.
prettier/prettier is already removed. Unicorn renamed these rules a long time ago.
`*` is an "explicit any!"
Continue making sure the code works everwhere.
Maybe ESM someday, but for now...
Turbo kills them otherwise, which is often fine, but breaks `test-run`.
Our custom error message handling was overly decentralized.
|
Thank you for your work on this @lishaduck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland the remaining changes from #126.
Depends on #168.
Here's the diff as GH doesn't play well with stacks from forks: lishaduck/node-elm-review@eslints...help-refactor