Replace fast-levenshtein with fastest-levenshtein #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elm-review uses `levenshtein.get(flag, f.name)` and does not pass the
option to use locale-sensitive string comparisons. This means that
`fast-levenshtein` does this:
```js
var levenshtein = require('fastest-levenshtein');
...
var Levenshtein = {
get: function(str1, str2, options) {
if (options.collate) { ... }
return levenshtein.distance(str1, str2);
}
...
}
```
See https://github.com/hiddentao/fast-levenshtein/blob/master/levenshtein.js#L84
|
Hey @marc136! |
|
No worries, even with vacation, it was only a week 👟 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #82 and removes one direct dependency and updates an indirect one.
fast-levenshtein@3.0.0 currently installs fastest-levenshtein@1.0.12 according to the package-lock.json.
I updated to 1.0.16 because I saw no indication that the compiled typescript output should no longer be compatible to node.js 10.0.0.
Currently, elm-review uses
levenshtein.get(flag, f.name)and does not pass the option to use locale-sensitive string comparisons. This means thatfast-levenshteindoes this:See https://github.com/hiddentao/fast-levenshtein/blob/master/levenshtein.js#L84
I think it should not create a merge conflict with #126, but I'm not sure.